Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish issues with mission difficulty dropdowns #19426

Merged
merged 3 commits into from
Jul 2, 2021

Conversation

Smittytron
Copy link
Member

@Smittytron Smittytron commented May 23, 2021

  • First commit fixes the TD dropdowns so that Normal isn't listed above Easy.
  • Second First commit also standardizes TD default mission difficulties to Normal like we did with RA in Miscellaneous mission improvements 4 #19392.
  • Last commit fixes the dropdown on the RA mission Down Under so that Normal appears selected.

@Smittytron Smittytron mentioned this pull request May 23, 2021
@Smittytron Smittytron force-pushed the difficulty-dropdown branch 3 times, most recently from 08228b9 to ebbd6e5 Compare May 23, 2021 15:02
@Smittytron
Copy link
Member Author

Updated. Moved the two TD commits into one generic one to avoid rebase issues.

@dragunoff
Copy link
Contributor

The changes here LGTM but there are a few RA missions that still have "easy" as the default.
image

Also, do we want to apply this to D2k as well? All of the missions there have "easy" as default.

@Smittytron
Copy link
Member Author

Added the RA changes. D2K has an 'easy' difficulty in every mission unlike RA and TD. After raising the question in Discord I'd like to leave D2K as is for now.

@reaperrr
Copy link
Contributor

reaperrr commented Jun 4, 2021

Added the RA changes. D2K has an 'easy' difficulty in every mission unlike RA and TD. After raising the question in Discord I'd like to leave D2K as is for now.

Sounds reasonable to me.
Besides, at least judging by the missions I've played, iirc our D2k missions are notably harder than in the original pretty much across the board, so I think defaulting to 'Easy' is fine from that angle as well.
Things fluctuate quite a bit more in RA and TD due to the larger variety of people who ported the missions.

reaperrr
reaperrr previously approved these changes Jun 27, 2021
@abcdefg30 abcdefg30 merged commit 347a09e into OpenRA:bleed Jul 2, 2021
@abcdefg30
Copy link
Member

Changelog

@Smittytron Smittytron deleted the difficulty-dropdown branch July 2, 2021 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants