Improve HitShape debug overlays #19467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abcdefg30
previously approved these changes
Jun 25, 2021
reaperrr
force-pushed
the
improve-hitshape-debug
branch
from
bb7e4cd
to
2d9d6bd
Compare
abcdefg30
previously approved these changes
Jun 25, 2021
pchote
reviewed
Jul 1, 2021
pchote
reviewed
Jul 1, 2021
|
LGTM. Neither of my comments above are blockers, so if you don't think they are worth changing then please go ahead and merge instead of replying and waiting for me to do it. |
Instead of disabling their debug overlay entirely.
HitShape Requires<BodyOrientation> anyway.
Instead of not rendering them at all. Also moved their debug overlay to HitShape.
reaperrr
force-pushed
the
improve-hitshape-debug
branch
from
2d9d6bd
to
4a779d6
Compare
|
Updated (and tested that everything still works). |
pchote
approved these changes
Jul 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of just not rendering disabled shapes and targetable positions, they're now rendered in light gray shades when their housing
HitShapetrait is disabled.Makes it easier to debug conditional HitShapes.
Also made
orientationreadonly sinceHitShapeRequires<BodyOrientation>anyway.I use this in one of my projects, so it would be nice if this were merged soonish so I can cut down the number of custom commits a bit for easier rebases/maintenance.
For those who don't feel like or don't know how to set up a testcase, this is what it looks like in-game:
