Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for TS-style tinted target flashes #19479

Merged
merged 4 commits into from Aug 2, 2021

Conversation

pchote
Copy link
Member

@pchote pchote commented Jul 1, 2021

Implementing the last piece from #18310, this PR hooks up an option to flash targets using the multiply effect from the original TS and enables it for the TS mod. The first commit fixes the incorrect intentation (spaces to tabs) that wasn't caught in #19444.

@pchote
Copy link
Member Author

pchote commented Jul 4, 2021

Fixed.

teinarss
teinarss previously approved these changes Jul 8, 2021
Copy link
Contributor

@teinarss teinarss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

@pchote
Copy link
Member Author

pchote commented Jul 8, 2021

Updated.

@abcdefg30 abcdefg30 merged commit 8fc042f into OpenRA:bleed Aug 2, 2021
@abcdefg30
Copy link
Member

Changelog

@pchote pchote deleted the flash-tint branch August 21, 2021 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants