Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ingame menu tab display. #19490

Merged
merged 2 commits into from Aug 7, 2021
Merged

Conversation

pchote
Copy link
Member

@pchote pchote commented Jul 5, 2021

This PR fixes the ingame panel tab strip to not overflow when there are too many visible tabs:

Screenshot 2021-07-05 at 21 56 26

Screenshot 2021-07-05 at 21 57 03

Screenshot 2021-07-05 at 21 59 08

Screenshot 2021-07-05 at 22 02 01

This includes templates for up to 5 tabs, simplifying the changes required by #19461.

Copy link
Contributor

@dragunoff dragunoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works fine with #19461

The file mods/ts/chrome/ingame-info.yaml is identical to mods/common/chrome/ingame-info.yaml. I don't think there's a good reason to keep the TS specific one around.

@pchote
Copy link
Member Author

pchote commented Aug 7, 2021

Fixed.

@Smittytron Smittytron merged commit edd3a2e into OpenRA:bleed Aug 7, 2021
@pchote pchote deleted the fix-ingame-info-panels branch August 21, 2021 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants