PathGraph, skip closed cells early. #19524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchote
reviewed
Jul 15, 2021
anvilvapre
force-pushed
the
20210716_perf_path_graph_skip_closed_early
branch
from
4e249b8
to
ccbbb7e
Compare
teinarss
previously approved these changes
Jul 25, 2021
abcdefg30
reviewed
Jul 26, 2021
Comment on lines
105
to
109
| foreach (var cml in world.GetCustomMovementLayers().Values) | ||
| { | ||
| if (cml.EnabledForActor(actor.Info, locomotorInfo)) | ||
| customLayerInfo[cml.Index] = (cml, pooledLayer.GetLayer()); | ||
| } |
There was a problem hiding this comment.
Suggested change
| foreach (var cml in world.GetCustomMovementLayers().Values) | |
| { | |
| if (cml.EnabledForActor(actor.Info, locomotorInfo)) | |
| customLayerInfo[cml.Index] = (cml, pooledLayer.GetLayer()); | |
| } | |
| foreach (var cml in world.GetCustomMovementLayers().Values) | |
| if (cml.EnabledForActor(actor.Info, locomotorInfo)) | |
| customLayerInfo[cml.Index] = (cml, pooledLayer.GetLayer()); |
Comment on lines
147
to
148
| var validNeighbors = new List<GraphConnection>(directions.Length + | ||
| (posLayer == 0 ? customLayerInfo.Count : 1)); |
There was a problem hiding this comment.
Suggested change
| var validNeighbors = new List<GraphConnection>(directions.Length + | |
| (posLayer == 0 ? customLayerInfo.Count : 1)); | |
| var validNeighbors = new List<GraphConnection>(directions.Length + (posLayer == 0 ? customLayerInfo.Count : 1)); |
In path finding GetConnections considers connections to already closed cells and calculates the cost for them. The caller afterwards ignores them. These are 15% of all connections.
anvilvapre
force-pushed
the
20210716_perf_path_graph_skip_closed_early
branch
from
ccbbb7e
to
72d877c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In path finding GetConnections considers connections to already closed cells and calculates the cost for them. The caller afterwards ignores them. These are 15% of all connections.
Originally part of a separate pull request that I will close in future #19245.