Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicate ActorIDs #19530

Merged
merged 1 commit into from Jul 17, 2021
Merged

Fix duplicate ActorIDs #19530

merged 1 commit into from Jul 17, 2021

Conversation

chrisharris333
Copy link
Contributor

@chrisharris333 chrisharris333 commented Jul 16, 2021 •
edited by Smittytron

Corrected duplicate ID detection mechanism.

Added code to actually display the error message.

Fixes #19286 and Closes #17895.

Smittytron
Smittytron approved these changes Jul 16, 2021
View reviewed changes
Copy link
Member

@Smittytron Smittytron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

@abcdefg30 abcdefg30 merged commit 1c6ca39 into OpenRA:bleed Jul 17, 2021
@abcdefg30
Copy link
Member

Changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abcdefg30 abcdefg30 abcdefg30 approved these changes

@Smittytron Smittytron Smittytron approved these changes

Assignees
No one assigned
Labels
PR: Needs +2
Projects
None yet
Milestone
No milestone
3 participants
@chrisharris333 @abcdefg30 @Smittytron