Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use FireClusterWarhead with barrels #19549

Merged
merged 2 commits into from
Sep 18, 2021
Merged

Use FireClusterWarhead with barrels #19549

merged 2 commits into from
Sep 18, 2021

Conversation

Smittytron
Copy link
Member

The original had four additional explosions adjacent to barrels; up, down, left, and right. These were their own explosion, not just a visual effect.

Closes #19079

@Smittytron
Copy link
Member Author

Below is a comparison with one barrel in Remastered vs one barrel in this PR. The biggest adjustment I had to do was with damage vs Wood, as per cell hitshapes are going to skew our numbers. I tested Allies05b (conyard) and some MP maps to make sure barrels by Oil Derricks didn't destroy them.

Original has linear falloff damage which we can do if we want. That would make barrels inconsistent with the falloff damage we have on everything else so I'm hesitant to do that.

OGbarrel
ra-2021-07-22T001215505Z

@abcdefg30 abcdefg30 added this to the Next release milestone Aug 19, 2021
@abcdefg30
Copy link
Member

The BarrelExplode (in the middle) has no LeaveSmudge warhead, is that intentional?

@Smittytron
Copy link
Member Author

Updated

abcdefg30
abcdefg30 previously approved these changes Sep 1, 2021
View reviewed changes
@Smittytron
Copy link
Member Author

Updated

Mailaender
Mailaender previously approved these changes Sep 17, 2021
View reviewed changes
Copy link
Member

@Mailaender Mailaender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes the barrel explosions more satisfying, in a way like how I remember them from RA95.

@Mailaender
Copy link
Member

Regression: destroying the barrels in allies03a will not kill the medic anymore. I guess that is unintentional.

@Smittytron
Copy link
Member Author

Smittytron commented Sep 17, 2021 •
edited
Loading

Regression: destroying the barrels in allies03a will not kill the medic anymore. I guess that is unintentional.

It has something to do with the dummy 'prison' actor that keeps the medic from from being targetable. I'm trying to wrap my head around if I need to add a workaround commit for Allies03a or make a change here.

@Smittytron
Copy link
Member Author

Added a commit to fix the issue with Allies03a. 03b does the same trick but doesn't have barrels around them.

@reaperrr reaperrr merged commit 99006a0 into OpenRA:bleed Sep 18, 2021
@reaperrr
Copy link
Contributor

https://github.com/OpenRA/OpenRA/wiki/Changelog-(bleed)/_compare/496436bcd107720c5d8cb0f9be7a7c3c94885617...11171a4e9b10a7f8fcdaa961c12bf9b63e02de77

@Smittytron Smittytron deleted the cluster-barrel branch September 18, 2021 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reaperrr reaperrr reaperrr approved these changes

@Mailaender Mailaender Mailaender left review comments

@abcdefg30 abcdefg30 abcdefg30 left review comments

Assignees
No one assigned
Labels
PR: Needs +2
Projects
None yet
Milestone
Release 20230225
Development

Successfully merging this pull request may close these issues.

Barrel explosions should create fireball effects in adjacent cells
4 participants
@Smittytron @abcdefg30 @Mailaender @reaperrr