Fix weather particle physics. #19596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The trait documentation specified that the speed and offset values are px/tick, but they have actually always been treated as px/render. Fix the update logic and rescale the map definitions to account for the fixed behaviour.
reaperrr
reviewed
Aug 8, 2021
| // SwingSpeed is defined in px/tick so we must account for the fraction of a tick that elapsed since the last render. | ||
| // The scale is capped at 1 tick to avoid unexpected behaviour at game start, if RunTime overflows, or if the game stalls. | ||
| var runtime = Game.RunTime; | ||
| var tickFraction = Math.Min((runtime - lastRender) * 1f / world.Timestep, 1); |
There was a problem hiding this comment.
tickFraction looks like something we might want to eventually calculate and expose at a central, publicly accessible place like Game, so we can reuse it for things like interpolation and don't need to do the math locally in every place that needs it.
Just thinking aloud, not a request for this particular PR.
There was a problem hiding this comment.
You are thinking of something like https://love2d.org/wiki/dt delta time?
reaperrr
approved these changes
Aug 20, 2021
|
Hey everybody, thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18025. See commit message for description.