Make yaml check utility load each map separately to reduce memory usage. #19649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abcdefg30
reviewed
Sep 1, 2021
Mailaender
previously approved these changes
Sep 17, 2021
abcdefg30
reviewed
Oct 12, 2021
RoosterDragon
approved these changes
Dec 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into an out of memory exception when building CA, and identified the problem being with the YAML check in the utility tool. It loads every map with a significant overhead before checking them, and CA with its 300+ maps ends up using about 8.5GB of RAM.
Running --check-yaml on the bleed RA mod uses approx 1.2GB of RAM. These changes reduce it to around 400MB.