Make the editor use an EchoConnection instead of a local server #19653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abcdefg30
force-pushed
the
fixEditorCon
branch
from
63224e3
to
79d9197
Compare
abcdefg30
changed the title
teinarss
approved these changes
Sep 6, 2021
|
The load screen is shown twice when creating a new map. |
|
This is actually already the case on bleed, but it seems to be too fast to witness normally (if you set a breakpoint at the right spot in |
|
The last release does not have this regression, although it is a lot less serious. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19652. We no longer join a local server, and move the shellmap-specific special case for adding a dummy client to
JoinLocalso it is re-used for the editor.