Changed SupportPower descriptors #19669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abcdefg30
reviewed
Sep 16, 2021
OpenRA.Mods.Common/UpdateRules/Rules/20201213/RenameSupportPowerDescription.cs
Outdated
Show resolved
Hide resolved
Mailaender
force-pushed
the
support-power-desc
branch
from
551fd8b
to
4e43831
Compare
abcdefg30
reviewed
Sep 17, 2021
OpenRA.Mods.Common/UpdateRules/Rules/20201213/RenameSupportPowerDescription.cs
Show resolved
Hide resolved
abcdefg30
previously approved these changes
Sep 18, 2021
reaperrr
previously approved these changes
Dec 5, 2021
|
LGTM, but needs a rebase. |
Mailaender
force-pushed
the
support-power-desc
branch
from
4e43831
to
cc8c35d
Compare
|
Rebased. |
reaperrr
approved these changes
Dec 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a somewhat pedantic field name change to bring in consistency, as
TooltipandTooltipDescriptionas well asBuildableuseNameandDescriptionLongDescviolates the unwritten field name rules by using a needless abbreviationDescriptionwas not really describing but used as a header in the UI