Locomotor, PathGraph, trivial optimizations. #19682
Conversation
| if (preferredSubCell != SubCell.Any && !AnyActorsAt(cell, preferredSubCell, checkIfBlocker)) | ||
| var uv = cell.ToMPos(map); | ||
| if (!influence.Contains(uv)) | ||
| return SubCell.Invalid; |
There was a problem hiding this comment.
This looks like a behaviour change. Beforehand AnyActorsAt would return false and then map.Grid.DefaultSubCell (or preferredSubCell) would be returned and not SubCell.Invalid?
There was a problem hiding this comment.
True. I now realize that Invalid is never the correct return value - but preferredCell or FirstCell.
When a cell is not on the map - a sub cell is returned - either the preferred or the first. The caller will not know it passed an off map cell. It might be better to return Invalid perhaps to allow the caller to cancel further processing. I.e. path planning may now continue longer than needed?
In the last push original behavior is maintained.
|
LGTM modulo the comment r.e. the change in behaviour. |
anvilvapre
force-pushed
the
20210909_locomotor_getcache
branch
from
1f824d2
to
3f33ea9
Compare
| @@ -272,9 +272,10 @@ public IEnumerable<Actor> GetActorsAt(CPos a, SubCell sub) | |||
| if (!influence.Contains(uv)) | |||
| yield break; | |||
|
|
|||
| var always = (sub == SubCell.FullCell || sub == SubCell.Any); | |||
There was a problem hiding this comment.
no need for the parentheses.
anvilvapre
force-pushed
the
20210909_locomotor_getcache
branch
from
3f33ea9
to
b3e487b
Compare
Do not check for each sub cell if mpos lies in map influence bounds. Save 5 calls for each cell.
Only traverse all bins if there are actors to remove.