Require an explicit launch path for mod registrations. #19687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also removes a workaround that allowed the current mod to be registered even if it defined a bogus path. Uses of Game.ExternalMods should therefore always use TryGetValue and correctly handle it returning false.
|
|
It was updated in #12600 so nothing needed to change here. |
|
Pushed a commit that adjusts the |
abcdefg30
approved these changes
Sep 29, 2021
teinarss
approved these changes
Nov 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19518.
Supersedes #19589.
Switching to .NET 5 broke (and is, in general, fundamentally incompatible with) the method we used to guess the launch path for external mod switching. This PR solves the problem by removing the assumption that it is always valid to switch to the currently active mod, and only registers mods that explicitly define a launch path. A new alert dialog is shown instead of the restart prompt if the settings are changed and we don't have a valid path for restarting the game.
We would ideally also update
launch-game.cmdto passEngine.LaunchPathsimilarly tolaunch-game.sh, but this goes beyond my level of ability and patience (having now spent well over an hour failing at what should have been a trivial change). We need tocd %~dp0%before thebin\OpenRA.exelines, and passEngine.LaunchPath="%~dpf0"to create the correct metadata file. The final issue is that theGame.Moddetection at the top of the script blocks the restart even though a valid argument is already specified.