Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed a crash when exits were determined from dead buildings #19709

Merged
merged 1 commit into from
Nov 18, 2021
Merged

Fixed a crash when exits were determined from dead buildings #19709

merged 1 commit into from
Nov 18, 2021

Conversation

Mailaender
Copy link
Member

Closes #19707

reaperrr
reaperrr previously approved these changes Oct 2, 2021
View reviewed changes
Copy link
Contributor

@reaperrr reaperrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested, but makes sense

@dnqbob
Copy link
Contributor

dnqbob commented Oct 2, 2021

going to test it

@dnqbob
Copy link
Contributor

dnqbob commented Oct 2, 2021

A sad thing is, I cannot reproduce it in replay. The replay itself is buggy due to game speed is too quick.

dnqbob added a commit to dnqbob/OpenRA that referenced this pull request Oct 2, 2021
@dnqbob
Exit dead check fix based on OpenRA/OpenRA#19709
1a1c513
@Mailaender Mailaender changed the title Fixed a crash where exits where determined from dead buildings Fixed a crash when exits where determined from dead buildings Oct 2, 2021
@Mailaender Mailaender changed the title Fixed a crash when exits where determined from dead buildings Fixed a crash when exits were determined from dead buildings Oct 28, 2021
@abcdefg30 abcdefg30 merged commit 98b25dd into OpenRA:bleed Nov 18, 2021
@abcdefg30
Copy link
Member

Changelog

@Mailaender Mailaender deleted the dead-exits branch November 18, 2021 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchote pchote pchote left review comments

@dnqbob dnqbob dnqbob left review comments

@RoosterDragon RoosterDragon RoosterDragon approved these changes

@abcdefg30 abcdefg30 abcdefg30 approved these changes

@reaperrr reaperrr reaperrr left review comments

Assignees
No one assigned
Labels
PR: Needs +2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A crash related with Exit trait (and probably plus AI)
6 participants
@Mailaender @dnqbob @abcdefg30 @pchote @reaperrr @RoosterDragon