Fixed Credits view crashing and unhardcoded AUTHORS file name/path #19739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The proper fix here will be to change https://github.com/OpenRA/OpenRA/blob/bleed/OpenRA.Mods.Common/Widgets/Logic/CreditsLogic.cs#L43 to use |
|
To be fair I kind of wanted to avoid that so I don't have to test the packaged build too. Also the proper fix would be to move that to the |
|
the mod.yaml path would still be |
penev92
force-pushed
the
fixCreditsView
branch
from
f8bfee3
to
6721119
Compare
abcdefg30
reviewed
Oct 12, 2021
Moved the file name/path to ModCredits, read from mod.yaml
penev92
force-pushed
the
fixCreditsView
branch
from
6721119
to
6f5decc
Compare
penev92
changed the title
|
Reworked/updated/fixed. |
phrohdoh
reviewed
Oct 16, 2021
abcdefg30
added
the
hacktoberfest-accepted
abcdefg30
approved these changes
Nov 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CREDITS view has been crashing because it can't find the AUTHORS file, most likely since the restructuring of the repository and the introduction of the bin folder.
Turns out that is only a problem when not specifically setting a different working directory (which I assume the launch scripts do, which is a whole lot of "why"s in itself, but I'm not going to go down that rabbit hole in this PR), so is probably only reproducible when running from Visual Studio (idk about Rider).