Added support for super weapon detected notifications #19811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mailaender
force-pushed
the
support-detected
branch
from
29365af
to
6244865
Compare
Mailaender
force-pushed
the
support-detected
branch
from
6244865
to
512f475
Compare
kantnisha
approved these changes
Nov 23, 2021
abcdefg30
approved these changes
Nov 27, 2021
| @@ -185,7 +202,6 @@ public virtual void PlayLaunchSounds() | |||
| var isAllied = Self.Owner.IsAlliedWith(renderPlayer); | |||
| Game.Sound.Play(SoundType.UI, isAllied ? Info.LaunchSound : Info.IncomingSound); | |||
|
|
|||
| // IsAlliedWith returns true if renderPlayer is null, so we are safe here. | |||
There was a problem hiding this comment.
I moved it to an XML comment, so it doesn't rot when the logic changes and for it to be visible from other places calling the function.
reaperrr
approved these changes
Dec 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required for https://github.com/OpenRA/ra2/blob/master/mods/ra2/audio/notifications.yaml