Code style rules readonly #19890
Merged
Code style rules readonly #19890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
None the the changes look to be for areas that would involve reflection, so happy with those. Currently the naming rules in editorconfig don't align with the |
Also added a rule to silence StyleCop complaining about StaticReadonlyFieldsMustBeginWithUpperCaseLetter to match what we already have configured for the IDE.
penev92
force-pushed
the
codeStyleRules-readonly
branch
from
aefd23e
to
07f312a
Compare
|
Moved the StyleCop rule to |
RoosterDragon
approved these changes
Jan 22, 2022
pchote
approved these changes
Jan 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step Nth in our quest for moar code style rules!!! Now we finally take on the infamous
readonlymodifier that gets skipped so often.Activating the rule (IDE0044) and fixing the subsequent issues lead to a new batch of issues - there are a bunch of places that light up with
error SA1311: Static readonly fields should begin with upper-case letter, which left me with two choices - silence that rule or fix these issues as well. I started fixing them, but at some point realized that rule IDE1006 (also configured in the.editorconfig) is the IDE version of the same thing and it is explicitly silenced, so as a first option I went with that. If people decide against it then I'll change it.P.S.: Big but incredibly easy to review PR 😛
Pinging @RoosterDragon for a review please.