Update uid generation to include map.png and update map format #19891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PunkPun
commented
Jan 20, 2022
PunkPun
force-pushed
the
Update-UID
branch
2 times, most recently
from
7044791
to
2cadf76
Compare
|
When I updated maps, some of the map previews were also updated. I excluded them from this pr except for TS. Their generation was changed in #19572 but the maps themselves weren't updated. I think this is a good opportunity to fix that mistake |
Mailaender
reviewed
Jan 21, 2022
pchote
reviewed
Jan 21, 2022
penev92
changed the title
PunkPun
force-pushed
the
Update-UID
branch
3 times, most recently
from
d3e8490
to
ef09881
Compare
pchote
reviewed
Jan 22, 2022
|
Can you please reorder the commits so that the parsing logic commit is first? Trying to build and run on any but the last commit currently crashes on startup. Otherwise LGTM. |
|
reordered |
Merged
|
Needs a rebase. |
|
rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #19888
To not break compatibility with resource centre I update map format to 12. However since format doesn't actually change I'm keeping compatibility with format 11