Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SDL to 2.0.20 #19897

Merged
merged 1 commit into from Apr 13, 2022
Merged

Update SDL to 2.0.20 #19897

merged 1 commit into from Apr 13, 2022

Conversation

teinarss
Copy link
Contributor

No description provided.

abcdefg30
abcdefg30 previously approved these changes Jan 23, 2022
@pchote
Copy link
Member

pchote commented Jan 23, 2022

This is giving the same assertion failed error on macOS as 2.0.17 was. Something must need to be changed in the build config, which will require another nuget update.

@pchote
Copy link
Member

pchote commented Jan 26, 2022

We should update to 2.0.20 while we're at it.

@penev92 penev92 added this to the Next release milestone Feb 5, 2022
@Mailaender
Copy link
Member

Platform is Linux
Engine version is {DEV_VERSION}
Runtime: .NET CLR 6.0.2
Renderer initialization failed. Check graphics.log for details.
Renderer initialization failed. Check graphics.log for details.
Exception of type `System.InvalidOperationException`: Failed to initialize platform-integration library. Check graphics.log for details.
   at OpenRA.Game.Initialize(Arguments args) in /home/matthias/Entwicklung/OpenRA/OpenRA.Game/Game.cs:line 347
   at OpenRA.Game.InitializeAndRun(String[] args) in /home/matthias/Entwicklung/OpenRA/OpenRA.Game/Game.cs:line 290
   at OpenRA.Launcher.Program.Main(String[] args) in /home/matthias/Entwicklung/OpenRA/OpenRA.Launcher/Program.cs:line 32
System.InvalidOperationException: No supported OpenGL profiles were found.
   at OpenRA.Platforms.Default.Sdl2PlatformWindow..ctor(Size requestEffectiveWindowSize, WindowMode windowMode, Single scaleModifier, Int32 batchSize, Int32 videoDisplay, GLProfile requestProfile, Boolean enableLegacyGL) in /home/matthias/Entwicklung/OpenRA/OpenRA.Platforms.Default/Sdl2PlatformWindow.cs:line 159
   at OpenRA.Platforms.Default.DefaultPlatform.CreateWindow(Size size, WindowMode windowMode, Single scaleModifier, Int32 batchSize, Int32 videoDisplay, GLProfile profile, Boolean enableLegacyGL) in /home/matthias/Entwicklung/OpenRA/OpenRA.Platforms.Default/DefaultPlatform.cs:line 21
   at OpenRA.Renderer..ctor(IPlatform platform, GraphicSettings graphicSettings) in /home/matthias/Entwicklung/OpenRA/OpenRA.Game/Renderer.cs:line 79
   at OpenRA.Game.Initialize(Arguments args) in /home/matthias/Entwicklung/OpenRA/OpenRA.Game/Game.cs:line 368
System.InvalidOperationException: No supported OpenGL profiles were found.
   at OpenRA.Platforms.Default.Sdl2PlatformWindow..ctor(Size requestEffectiveWindowSize, WindowMode windowMode, Single scaleModifier, Int32 batchSize, Int32 videoDisplay, GLProfile requestProfile, Boolean enableLegacyGL) in /home/matthias/Entwicklung/OpenRA/OpenRA.Platforms.Default/Sdl2PlatformWindow.cs:line 159
   at OpenRA.Platforms.Default.DefaultPlatform.CreateWindow(Size size, WindowMode windowMode, Single scaleModifier, Int32 batchSize, Int32 videoDisplay, GLProfile profile, Boolean enableLegacyGL) in /home/matthias/Entwicklung/OpenRA/OpenRA.Platforms.Default/DefaultPlatform.cs:line 21
   at OpenRA.Renderer..ctor(IPlatform platform, GraphicSettings graphicSettings) in /home/matthias/Entwicklung/OpenRA/OpenRA.Game/Renderer.cs:line 79
   at OpenRA.Game.Initialize(Arguments args) in /home/matthias/Entwicklung/OpenRA/OpenRA.Game/Game.cs:line 368

@teinarss
Copy link
Contributor Author

@Mailaender can you try to downgrade the sdl2.so to 2.0.16 and also test update to 2,020?

@Mailaender
Copy link
Member

Both 2.0.8 and 2.0.20 crash.

@teinarss
Copy link
Contributor Author

Both 2.0.8 and 2.0.20 crash.

What about 2,0,16? The one we are using on bleed. Also does it work on bleed for you (without using the environment var?)

Otherwise the only thing I can suggest is to link directly to https://github.com/teinarss/SDL2-CS/tree/nugetified and see which commit starts to crash.

@Mailaender
Copy link
Member

If 2.0.16 is the one I am using all the time, by default, then that works without problems.

@Mailaender
Copy link
Member

Comparing https://nuget.info/packages/OpenRA-SDL2-CS/1.0.28 to https://nuget.info/packages/OpenRA-SDL2-CS/1.0.30 I see a new SDL2-CS-legacy.dll.config

<?xml version="1.0" encoding="utf-8"?>
<configuration>
	<dllmap os="!windows" dll="SDL2.dll" target="libSDL2-2.0.so.0" />
	<dllmap os="openbsd" dll="SDL2.dll" target="libSDL2.so" />
	<dllmap os="osx" dll="SDL2.dll" target="libSDL2.dylib"/>
</configuration>

However the package does not ship those.

@Mailaender
Copy link
Member

https://nuget.info/packages/OpenRA-SDL2-CS/1.0.29 also fails on Linux.

@teinarss teinarss changed the title Update SDL to 2.0.18 Update SDL to 2.0.20 Apr 13, 2022
@teinarss
Copy link
Contributor Author

Updated.

Copy link
Member

@pchote pchote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working on macOS

Copy link
Member

@Mailaender Mailaender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine on Linux

@Mailaender Mailaender merged commit 515aba0 into OpenRA:bleed Apr 13, 2022
@Mailaender
Copy link
Member

Changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants