Add the possibility to always show detection circles #19899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reaperrr
reviewed
Jan 30, 2022
| return RenderCircle(self, wr, DetectionCircleVisibility.Always); | ||
| } | ||
|
|
||
| bool IRenderAnnotations.SpatiallyPartitionable => false; |
There was a problem hiding this comment.
Just throwing it in here: We should get around to enabling spatial partitioning on any kind of circles at some point, right now we're rendering any visible circles all the time, regardless of how far they are from the viewport.
reaperrr
approved these changes
Jan 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19830.
Testcase: Add
Visible: Alwaysto theRenderDetectionCircletraits of minelayers or subs in RA.