Add contexts for hotkey validation #19900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abcdefg30
previously approved these changes
Jan 25, 2022
|
Needs a rebase. |
dragunoff
force-pushed
the
feature/hotkey-contexts-logic
branch
from
e6acaa6
to
c64fc7a
Compare
|
Rebased. |
Mailaender
approved these changes
Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the logic for hotkey contexts. It adds a
Contextsfield to hotkeys which is used for validation (i.e. hotkeys that share a context cannot overlap). TheTypesfield is now used solely for grouping in the settings panel.The code changes here are fairly simple, the bulk of the diff is yaml and I used the opportunity to review whether hotkeys are added to the relevant contexts. I pondered at adding a "Replay" context (because of the replay speed keys) but I decided to keep it simple and just use the "Spectator" context.
This is the first part of #19898. The other (and trickier part) is to implement a UI for the settings panel that displays the contexts to the user.