Preallocate dictionary size in ToDictionaryWithConflictLog #19907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I suspect the build failure will be solved by #19902 |
Only the build compiling with Mono is failing:
Does Mono not contain this method? |
|
No, it was added in net 6.
…On Sun, 30 Jan 2022, 11:38 abcdefg30, ***@***.***> wrote:
I suspect the build failure will be solved by #19902
<#19902>
Only the build compiling with Mono is failing:
Exts.cs(410,11): error CS1061: 'IEnumerable' does not contain a definition
for 'TryGetNonEnumeratedCount' and no accessible extension method
'TryGetNonEnumeratedCount' accepting a first argument of type 'IEnumerable'
could be found (are you missing a using directive or an assembly
reference?) [/home/runner/work/OpenRA/OpenRA/OpenRA.Game/OpenRA.Game.csproj]
Does Mono not contain this method?
—
Reply to this email directly, view it on GitHub
<#19907 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AESI7GA7RYB3UI3SGYDFVR3UYUIJ7ANCNFSM5NDJM3YQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
Then we might need to add a Mono only path that uses the old code. |
RoosterDragon
force-pushed
the
conflict-dict-alloc
branch
from
edae15c
to
dc15b62
Compare
|
Switched to a cast on |
|
Makes sense 👍 |
abcdefg30
reviewed
Jan 31, 2022
RoosterDragon
force-pushed
the
conflict-dict-alloc
branch
from
dc15b62
to
bcc5a8a
Compare
abcdefg30
approved these changes
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This saves some allocations in MiniYaml parsing on startup, but with also benefit other callers of the method.