After NotBefore<> support to control initialization order. #19928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teinarss
reviewed
Feb 6, 2022
RoosterDragon
force-pushed
the
after
branch
2 times, most recently
from
4e0981c
to
42f20cc
Compare
|
Updated the tests to ensure the the interfaces/inheritance was tested with |
abcdefg30
reviewed
Feb 8, 2022
RoosterDragon
force-pushed
the
after
branch
2 times, most recently
from
ba76621
to
ef6ef01
Compare
|
Moved the new |
teinarss
previously approved these changes
Apr 3, 2022
Requires<T> means that trait of type T will be initialized first, and asserts that at least one exists. The new NotBefore<T> means that trait of type T will be initialized first, but allows no traits. This allows traits to control initialization order for optional dependencies. They want to be initialized second so they can rely on the dependencies having been initialized. But if the dependencies are optional then to not throw if none are present. We apply this to Locomotor which was previously using AddFrameEndTask to work around trait order initialization. This improves the user experience as the initialization is applied whilst the loading screen is still visible, rather than the game starting and creating jank by performing initialization on the first tick.
|
Per some bikeshedding on Discord, have renamed the trait from |
RoosterDragon
changed the title
pchote
approved these changes
Apr 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires<T>means that trait of typeTwill be initialized first, and asserts that at least one exists. The newNotBefore<T>means that trait of typeTwill be initialized first, but allows no traits.This allows traits to control initialization order for optional dependencies. They want to be initialized second so they can rely on the dependencies having been initialized. But if the dependencies are optional then to not throw if none are present.
We apply this to
Locomotorwhich was previously usingAddFrameEndTaskto work around trait order initialization. This improves the user experience as the initialization is applied whilst the loading screen is still visible, rather than the game starting and creating jank by performing initialization on the first tick.Recommend using the
Hide Whitespaceoption when looking atLocomotor.csfor clarity.Changelog notes will want to cover:
NotBefore<T>interface to complementRequires<T>.ICustomMovementLayershould now also tag theirTraitInfowithICustomMovementLayerInfo.