Corrected StartBurstReport sound synchronisation when used with FireDelay #19931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkademic
force-pushed
the
pr/startburstreport-firedelay-fix
branch
from
6817d42
to
af56041
Compare
abcdefg30
approved these changes
Feb 14, 2022
RoosterDragon
approved these changes
Feb 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Has been a while since I raised #18729 so thought I'd have a stab at fixing it.
The issue was that Burst is updated every tick, but FireDelay causes the value to be out of sync as it'll check Burst when the delayed action actually gets called, by which point the value of Burst will have changed, when it needed to use the value of Burst at the point the delayed action was created.
So the solution just includes the Burst value in the delayed action tuple so that can be passed into the action function.
Seems to work fine.
So an Armament with FireDelay > 0 whose weapon has Burst > 1 should now correctly only play the StartBurstReport sound on the first shot (after the delay) and not subsequently, until the next salvo.
Closes #18729