Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make WithVoxelWalkerBody PausableConditional. #19932

Merged
merged 1 commit into from Feb 18, 2022
Merged

Make WithVoxelWalkerBody PausableConditional. #19932

merged 1 commit into from Feb 18, 2022

Conversation

MustaphaTR
Copy link
Member

Needed this for something in RV, it is pretty straightforward so decided to make a PR here too.

reaperrr
reaperrr approved these changes Feb 18, 2022
View reviewed changes
Copy link
Contributor

@reaperrr reaperrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested, but code changes look good and I assume this was tested for RV anyway. LGTM.

@reaperrr reaperrr merged commit 91f626c into OpenRA:bleed Feb 18, 2022
@MustaphaTR MustaphaTR deleted the conditional-wvwb branch February 18, 2022 11:25
@reaperrr
Copy link
Contributor

https://github.com/OpenRA/OpenRA/wiki/Changelog-(bleed)/_compare/e43529b5c428a08a81ab5288b036fed5ccf1e9c3...231c1a890eefb5f83d871b3dcbd2785b930d51ba

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reaperrr reaperrr reaperrr approved these changes

@abcdefg30 abcdefg30 abcdefg30 approved these changes

Assignees
No one assigned
Labels
PR: Needs +2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MustaphaTR @reaperrr @abcdefg30