Update variables for Flash lua function.

[MustaphaTR]

Another issue that was reported on #19920. The variables doesn't match the effect and Duration was being passed as alpha. I couldn't find any use of this in base mods, i assume that's why the issue wasn't found out so far.

Also replaced asPlayer with just Color, you can just use Player.Color as color variable.

I asked on Discord about float variables, it seems to be currently not possible in Lua so i left the Alpha value as the default 0.5f instead of making it settable.

[RoosterDragon]

Are there any usages of the function that need updating?

[MustaphaTR]

Are there any usages of the function that need updating?

I couldn't find any use of this in base mods, i assume that's why the issue wasn't found out so far.

[abcdefg30]

It would still be better to have a method with the old signature and a deprecation warning.

[MustaphaTR]

Old method was broken a good while ago, there is no longer a duration variable to give to FlashTarget effect to make it actually work and it was being passed as Alpha value. I don't see any point on keeping it as broken and not sure how fixed one would work there.

[abcdefg30]

Yes, it wouldn't work properly. But since we can't lint/update Lua scripts automatically changing the signature will crash scripts during execution with a more or less helpful message. Therefore we usually used deprecation. I'm also not convinced this worth the effort here, but it'd still be "nicer"/better to have it.

[MustaphaTR]

Updated.

[abcdefg30]

Ah crap, now we get an error on the shellmap of RA:
Actor 'rock6' defines the command 'Flash' on multiple traits
I guess the Lua bridge can't handle multiple signatures, so we probably need to remove the deprecated method after all. 😞
Sorry for the back and forth.

[MustaphaTR]

Updated.

[abcdefg30]

Changelog