Split NukePower MissileImage from MissileWeapon and make it optional #19955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abcdefg30
reviewed
Mar 15, 2022
MustaphaTR
force-pushed
the
split-missile-image
branch
from
328f03b
to
3432213
Compare
|
Updated. |
Mailaender
approved these changes
Apr 9, 2022
RoosterDragon
approved these changes
Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something i had noticed while editing MissileWeapon to use SW Level logic i have in RV Engine.
I also made it optional, not sure what his exact reasoning was but dnqbob had changed most SWs in SP to NukePower mostly with a dummy image, so making it optional here would remove need for the dummy image there. Not sure if there would be a more legit usecase of not having a missile image. I'm a bit unsure with how i handled it tho, as i had to add null or empty checks to 5 places in that file.
Also would be nice, if someone can reword the update rule name/descs, i dunno if i like what i wrote there.