Fix Army Spectator tab not using FactionImages #19956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoosterDragon
previously approved these changes
Apr 12, 2022
MustaphaTR
dismissed stale reviews from RoosterDragon and dragunoff
via
32a563d
MustaphaTR
force-pushed
the
fix-army-tab-faction-image
branch
from
3409edf
to
32a563d
Compare
|
Rebased and removed the testcase. |
RoosterDragon
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18433. I had not investigated the issue when i first noticed it, seems like it was just because the visible name of the faction was being passed in GetImage, instead of the InternalName.
Added a testcase that makes D2k buildings appear on the Army tab.