Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed client crashing when joining a game directly after asset installation #19975

Merged
merged 1 commit into from
Apr 16, 2022

Conversation

Mailaender
Copy link
Member

@Mailaender Mailaender commented Apr 13, 2022

Fixes #19973. To reproduce, create a Support directory in the OpenRA main folder and join a local dedicated server with 2 players then start the game.

OpenRA.Game/Translation.cs Outdated Show resolved Hide resolved
Copy link
Member

@pchote pchote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, a couple more that I missed first time.

OpenRA.Game/ModData.cs Outdated Show resolved Hide resolved
OpenRA.Game/Network/LocalizedMessage.cs Outdated Show resolved Hide resolved
@Mailaender
Copy link
Member Author

Updated.

@Mailaender Mailaender added this to the Next release milestone Apr 15, 2022
@penev92
Copy link
Member

penev92 commented Apr 16, 2022

Works as advertised 👍

@penev92 penev92 merged commit 648c56b into OpenRA:bleed Apr 16, 2022
@penev92
Copy link
Member

penev92 commented Apr 16, 2022

Changelog

@Mailaender Mailaender deleted the l10n-first-start branch April 17, 2022 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Joining a dedicated server crashes the client
3 participants