Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix selected map in server creation panel not updating #19990

Merged
merged 2 commits into from Aug 10, 2023
Merged

Fix selected map in server creation panel not updating #19990

merged 2 commits into from Aug 10, 2023

Conversation

PunkPun
Copy link
Member

@PunkPun PunkPun commented Apr 22, 2022 •
edited

fixes #19988

@PunkPun PunkPun force-pushed the fix-multiplayer-lobby-crash branch from 6a57a50 to 8a4bc01 Compare April 22, 2022 20:36
@pchote pchote added this to the Next release milestone Apr 23, 2022
abcdefg30
abcdefg30 reviewed Apr 25, 2022
View reviewed changes
Copy link
Member

@abcdefg30 abcdefg30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm otherwise.

OpenRA.Mods.Common/Widgets/Logic/ServerCreationLogic.cs Show resolved Hide resolved
@pchote
Copy link
Member

pchote commented Apr 30, 2022

This PR will likely be superseded by the more general fix needed for #20012.

@PunkPun PunkPun mentioned this pull request May 8, 2022
Merged
@PunkPun PunkPun force-pushed the fix-multiplayer-lobby-crash branch 2 times, most recently from 0c169f9 to 6f664ae Compare May 9, 2022 06:08
@PunkPun
Copy link
Member Author

PunkPun commented May 9, 2022

Rebased on #20031, I implemented the smart updating from that pr

@PunkPun PunkPun force-pushed the fix-multiplayer-lobby-crash branch from 6f664ae to a3395c8 Compare July 17, 2022 21:29
Mailaender
Mailaender previously approved these changes Aug 6, 2022
View reviewed changes
Copy link
Member

@Mailaender Mailaender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix confirmed.

@abcdefg30
Copy link
Member

👎 to not continuing after an update.

@PunkPun
Copy link
Member Author

PunkPun commented Oct 21, 2022

👎 to not continuing after an update.

#20318 will allow us to implement an interactive preview here, so as the update will not be automatic but manual this will no longer be a concern

@PunkPun
Copy link
Member Author

PunkPun commented Nov 4, 2022

Rebased on top of #20318 and implemented smart map preview

@PunkPun PunkPun modified the milestones: Next release, Next + 1 Dec 8, 2022
@PunkPun PunkPun modified the milestones: Next Release, Next + 1 Jun 16, 2023
@PunkPun PunkPun force-pushed the fix-multiplayer-lobby-crash branch from 2e188cf to 836ecd0 Compare August 5, 2023 17:03
@PunkPun PunkPun force-pushed the fix-multiplayer-lobby-crash branch from 836ecd0 to 7c844d1 Compare August 5, 2023 19:59
@PunkPun PunkPun force-pushed the fix-multiplayer-lobby-crash branch from 7c844d1 to 3a9ebea Compare August 7, 2023 20:14
@Mailaender Mailaender merged commit e22d7b3 into OpenRA:bleed Aug 10, 2023
3 checks passed
@Mailaender
Copy link
Member

Changelog

@PunkPun PunkPun deleted the fix-multiplayer-lobby-crash branch August 10, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchote pchote pchote left review comments

@abcdefg30 abcdefg30 abcdefg30 left review comments

@Mailaender Mailaender Mailaender approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Next Release
Development

Successfully merging this pull request may close these issues.

Map not found exception thrown when editing a map selected for a local server
4 participants
@PunkPun @pchote @abcdefg30 @Mailaender