Fix selected map in server creation panel not updating#19990
Merged
Mailaender merged 2 commits intoOpenRA:bleedfrom Aug 10, 2023
Merged
Fix selected map in server creation panel not updating#19990Mailaender merged 2 commits intoOpenRA:bleedfrom
Mailaender merged 2 commits intoOpenRA:bleedfrom
Conversation
PunkPun
force-pushed
the
fix-multiplayer-lobby-crash
branch
from
6a57a50 to
8a4bc01
Compare
Member
|
This PR will likely be superseded by the more general fix needed for #20012. |
PunkPun
force-pushed
the
fix-multiplayer-lobby-crash
branch
2 times, most recently
from
0c169f9 to
6f664ae
Compare
Member
Author
|
Rebased on #20031, I implemented the smart updating from that pr |
PunkPun
force-pushed
the
fix-multiplayer-lobby-crash
branch
from
6f664ae to
a3395c8
Compare
Member
|
👎 to not continuing after an update. |
Member
Author
#20318 will allow us to implement an interactive preview here, so as the update will not be automatic but manual this will no longer be a concern |
PunkPun
force-pushed
the
fix-multiplayer-lobby-crash
branch
from
a3395c8 to
2e188cf
Compare
Member
Author
|
Rebased on top of #20318 and implemented smart map preview |
PunkPun
force-pushed
the
fix-multiplayer-lobby-crash
branch
from
2e188cf to
836ecd0
Compare
PunkPun
force-pushed
the
fix-multiplayer-lobby-crash
branch
from
836ecd0 to
7c844d1
Compare
PunkPun
force-pushed
the
fix-multiplayer-lobby-crash
branch
from
7c844d1 to
3a9ebea
Compare
Mailaender
approved these changes
Aug 10, 2023
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #19988