Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle exceptions thrown by HttpClient.GetAsync. #19998

Merged
merged 1 commit into from
Apr 23, 2022
Merged

Handle exceptions thrown by HttpClient.GetAsync. #19998

merged 1 commit into from
Apr 23, 2022

Conversation

pchote
Copy link
Member

@pchote pchote commented Apr 23, 2022

Fixes #19981.

@pchote pchote added this to the Next release milestone Apr 23, 2022
RoosterDragon
RoosterDragon reviewed Apr 23, 2022
View reviewed changes
OpenRA.Mods.Common/WebServices.cs
Game.RunAfterTick(() => ModVersionStatus = status);
Game.RunAfterTick(() => ModVersionStatus = status);
}
catch { }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth a Log.Write?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so - lack of an internet connection isn't that unusual (considering that this code is triggered from the main menu on launch), and we have a couple of other cases where failed queries don't log.

@abcdefg30 abcdefg30 merged commit 0dbd826 into OpenRA:bleed Apr 23, 2022
@abcdefg30
Copy link
Member

Changelog

@pchote pchote deleted the fix-httpclient branch August 24, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RoosterDragon RoosterDragon RoosterDragon approved these changes

@abcdefg30 abcdefg30 abcdefg30 approved these changes

@teinarss teinarss teinarss approved these changes

Assignees
No one assigned
Labels
PR: Needs +2
Projects
None yet
Milestone
Release 20230225
Development

Successfully merging this pull request may close these issues.

HttpClient hangs if an internet connection isn't available
4 participants
@pchote @abcdefg30 @RoosterDragon @teinarss