Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gracefully handle trying to find paths outside the map. #20001

Merged
merged 1 commit into from May 22, 2022
Merged

Gracefully handle trying to find paths outside the map. #20001

merged 1 commit into from May 22, 2022

Conversation

RoosterDragon
Copy link
Member

Rather than crashing, return no path instead.

Fixes #20000

@pchote pchote added this to the Next release milestone Apr 23, 2022
@RoosterDragon
Gracefully handle trying to find paths outside the map.
0b136d4 
Rather than crashing, return no path instead.
abcdefg30
abcdefg30 approved these changes May 2, 2022
View reviewed changes
Copy link
Member

@abcdefg30 abcdefg30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes lgtm.

@atlimit8 atlimit8 merged commit 8904201 into OpenRA:bleed May 22, 2022
@atlimit8
Copy link
Member

Changelog

@RoosterDragon RoosterDragon deleted the path-map-bounds branch May 25, 2022 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchote pchote pchote left review comments

@abcdefg30 abcdefg30 abcdefg30 approved these changes

Assignees
No one assigned
Labels
PR: Needs +2
Projects
None yet
Milestone
Release 20230225
Development

Successfully merging this pull request may close these issues.

Crash due to Huntable actors outside map boundaries
4 participants
@RoosterDragon @atlimit8 @pchote @abcdefg30