Fixed a crash when loading empty video files #20006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abcdefg30
reviewed
Apr 24, 2022
Mailaender
force-pushed
the
empty-vqa
branch
3 times, most recently
from
8e0dd60
to
bded50d
Compare
abcdefg30
reviewed
Apr 24, 2022
abcdefg30
reviewed
May 15, 2022
There was a problem hiding this comment.
Works as advertised. It does look a bit weird though without feedback to the user:
Can we add a label that the video loading failed? The label can be set up to be only visible when video is null, so it shouldn't require invasive changes to the VideoPlayerWidget.
|
No, that is not required in my opinion. |
penev92
previously approved these changes
Jul 2, 2022
I took the liberty to rebase and squash. |
abcdefg30
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19124