Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added launch profiles for the Utility project #20009

Merged
merged 2 commits into from May 16, 2022

Conversation

penev92
Copy link
Member

@penev92 penev92 commented Apr 26, 2022

No description provided.

.vscode/launch.json Outdated Show resolved Hide resolved
@penev92
Copy link
Member Author

penev92 commented Apr 26, 2022

I don't know if it would be of any use, but I added a VSCode task to run the utility after a prompt by @abcdefg30 on Discord.

Copy link
Member

@atlimit8 atlimit8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me,

@atlimit8 atlimit8 merged commit 6eb4fe8 into OpenRA:bleed May 16, 2022
@atlimit8
Copy link
Member

Changelog

@@ -45,5 +45,19 @@
"args": ["Game.Mod=ts", "Engine.EngineDir=.."],
"preLaunchTask": "build",
},
{
"name": "Launch Utility",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually "Generate Trait Documentation",

"windows": {
"program": "${workspaceRoot}/bin/OpenRA.Utility.exe",
},
"args": ["all", "--docs", "{DEV_VERSION}"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you add this hard-coded when there is a more flexible task below?

"profiles": {
"OpenRA.Utility": {
"commandName": "Project",
"commandLineArgs": "all --docs {DEV_VERSION}",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems redundant to the one beforehand.

@penev92
Copy link
Member Author

penev92 commented Aug 19, 2022

@Mailaender the VS launch profile (OpenRA.Utility/Properties/launchSettings.json) and the VSCode launch configuration (.vscode/launch.json) are two entirely separate things and each is used by the respective IDE, so we need both.
The default values are there as a placeholder and an example on how to use them.

@penev92 penev92 deleted the utilityLaunchProfies branch September 2, 2022 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants