Minor performance and style improvements

[eduherminio]

Feel free to cherry-pick only some of the commits (or none of them!)

All these changes have been detected by static analysis and auto-resolved using VS suggestions, otherwise I wouldn't date to send such a length PR.

• Count() -> .Count() or .Length when possible
• Any() -> .Count() or .Length when possible
• Remove setters when possible
• Use pattern matching when possible (avoiding double casting)
• Simplify string comparison (x.ToLowerInvariant() == y -> string.Equals(x, y, StringComparison.InvariantCultureIgnoreCase))
• Simplify collection initialization when possible
• Protected constructor in abstract class
• Remove unnecessarily interpolated strings
• Simplify always true exceptions (b805481, please review carefully)

[abcdefg30]

Changes/Ideas look good to me overall, just a few comments. We'll also want to squash the commits to a lower number in the end.

[eduherminio]

Changes/Ideas look good to me overall, just a few comments. We'll also want to squash the commits to a lower number in the end.

I (think I) addressed all the comments, do you want me to try to logically groups commits or just squash everything when you merge it?

[RoosterDragon]

For any issues that are fully resolved, can we add the corresponding dotnet_diagnostic.XXYYYY.severity = warning line into .editorconfig so they get flagged automatically in the future?

[abcdefg30]

do you want me to try to logically groups commits or just squash everything when you merge it?

Ideal would be one commit per "change", i.e. one for .Any() -> .Count or .Length, one for removing the private setters etc. (But if that is too much work for you, I also wouldn't mind if you squashed it down to fewer commits.)

[eduherminio]

do you want me to try to logically groups commits or just squash everything when you merge it?

Ideal would be one commit per "change", i.e. one for .Any() -> .Count or .Length, one for removing the private setters etc. (But if that is too much work for you, I also wouldn't mind if you squashed it down to fewer commits.)

Done @abcdefg30, also added @RoosterDragon's suggestion

[abcdefg30]

Can you squash the space -> tab fixup into the "Use pattern matching" commit (where I think the change first happens)? (So that we don't have random revert commits in the history.) LGTM afterwards.

[eduherminio]

Can you squash the space -> tab fixup into the "Use pattern matching" commit (where I think the change first happens)? (So that we don't have random revert commits in the history.) LGTM afterwards.

👍🏼 Squashed and rebased.

[abcdefg30]

Sorry, found two more small things.

[atlimit8]

I found one probable issue and a minor nit.

[atlimit8]

NOTE: I don't know why my comment for this line was not added to my last review; I probably forgot to add it to the review. That is why I have been waiting.

[atlimit8]

Changelog