Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more map editor hotkeys #20029

Merged
merged 3 commits into from Jun 10, 2022
Merged

Conversation

dragunoff
Copy link
Contributor

Adds hotkeys to map editor tabs (Tiles, Actors, Overlays, History) and overlay toggles (Grid, Buildable Terrain).

image

Depends on #20028 (not really dependent on it, but the copy, undo/redo keys are)

@pchote pchote added this to the Next release milestone May 6, 2022
pchote
pchote previously approved these changes May 7, 2022
Copy link
Member

@pchote pchote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested on macOS and Linux.

@pchote
Copy link
Member

pchote commented May 7, 2022

Needs a rebase now.

@dragunoff
Copy link
Contributor Author

Rebased.

abcdefg30
abcdefg30 previously approved these changes May 9, 2022
Copy link
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TD map editor seems to be working very well, however that is not true in all 3 other mods. Overlay hotkeys do nothing and one can't even open the overlay checkbox panel

@dragunoff
Copy link
Contributor Author

Rebased and fixed the oversight of not adding the keyhandler to the common editor yaml (#20029 (review)).

Copy link
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@abcdefg30 abcdefg30 merged commit 320228f into OpenRA:bleed Jun 10, 2022
@abcdefg30
Copy link
Member

Changelog

@dragunoff dragunoff deleted the feature/editor-hotkeys branch June 10, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants