Change macOS control group defaults back to Cmd. #20030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragunoff
approved these changes
May 9, 2022
|
This PR should be reverted. We conflict with native OSX hotkeys #17039 |
|
Another option for the user: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the new plumbing introduced in #20028 to restore the pre-#19666 behaviour on macOS.
This change was forced by necessity at the time, and while there are arguments that it may be wanted for other reasons, IMO that should be discussed and PRed as its own feature. If and until then, we should restore the previous behaviour to avoid breaking the muscle memory of existing players.