Add support for readonly hotkeys and expose chat input hotkeys #20033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragunoff
force-pushed
the
feature/readonly-hotkeys
branch
from
4db3681
to
0a05f93
Compare
abcdefg30
reviewed
May 11, 2022
OpenRA.Mods.Common/Widgets/Logic/Settings/HotkeysSettingsLogic.cs
Outdated
Show resolved
Hide resolved
dragunoff
force-pushed
the
feature/readonly-hotkeys
branch
from
0a05f93
to
f241d9b
Compare
|
Update: rebased and addressed #20033 (review) |
abcdefg30
reviewed
May 13, 2022
OpenRA.Mods.Common/Widgets/Logic/Settings/HotkeysSettingsLogic.cs
Outdated
Show resolved
Hide resolved
dragunoff
force-pushed
the
feature/readonly-hotkeys
branch
from
f241d9b
to
04ebe6a
Compare
|
Update: addressed #20033 (comment) |
abcdefg30
approved these changes
May 13, 2022
|
IMO this feels wrong, but I guess it's intentional?
vs
(Open * Chat is defined under the Player context, so disappears when filtering by Chat). I don't want to hold up this PR further, so this can be iterated on (if wanted) in a future PR. |
pchote
approved these changes
Jun 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another in my line of hotkey related PRs but I guess this one's gonna be a bit controversial. The motivation for this feature is to expose the hard-coded chat input hotkeys to the user.
Read-only hotkey in the new "Chat Input" context
A conflict with a read-only hotkey