Added lobby sounds for leave, join and option change

[Mailaender]

Closes #6246

[PunkPun]

Were the sounds in the original games? All mods sound fine except for RA, it just feels like those sounds belong to TD, not RA

We should also play the leave sound for the person who's leaving as we play a sound on join. Currently the leave is only played for other players.

Imo skirmish / missions lobbies should play the sounds as well, the game would feel more responsive

[dragunoff]

I like the idea of a doppler effect for join/leave sounds but I don't like the sound effects that are available in the original games. Especially the join/leave ones - I find them too intrusive. From @Smittytron's selection in #6246 I find the RA sounds most pleasing as they are subtle.

I'd suggest that for now we can keep it simple and use the same sound for leave, join and option change. Or maybe even don't change the sounds at all but just add the plumbing. Mods can then take advantage of it and in the future we may revisit this.

[Mailaender]

Used the same sound for all notifications instead of the selection picked by @Smittytron. Made all lobby beeps optional, including the chat beep missing won't crash the game.

[PunkPun]

There are no sounds for D2K and TS

We should also play the leave sound for the person who's leaving as we play a sound on join. Currently the leave is only played for other players

still stands

And for beeping sounds we should really use InterruptType: Overlap. It just sounds better. Though I guess for chat we can leave Interrupt so that after a lag spyke you wouldn't get a very loud beep

[Mailaender]

There are no sounds for D2K and TS

No sounds for Tiberian Sun is intentional. I needed a test case and the proposed sounds were all from in-game.

We should also play the leave sound for the person who's leaving as we play a sound on join. Currently the leave is only played for other players

No idea how to solve that. If you leave the lobby, the lobby can't send you a beep.

[PunkPun]

We can just play the sound separately. Not via notifications

[Mailaender]

Fixed the Dune 2000 sounds and changed the interrupt types. Added the player left sound when you press disconnect.

[penev92]

Playing a leave sounds to the person that has already left the lobby sounds weird.

[PunkPun]

Currently it's silent when you join a singleplayer lobby, or when you leave any lobby. If we are adding sounds to entering and leaving then we should be consistent

[abcdefg30]

I don't think we should play a sound for either oneself entering or leaving the lobby.

[PunkPun]

for me personally the absence of sound is offputting. Besides the fact that it would be inconsistent not to have it, in general I think it's really nice polish to have sound for entering major sequences

[matjaeck]

The usecase is to notify lobby members that a player-change in the lobby has happened. It is consistent to not play the sound for the person joining or leaving, as that person can not be considered a lobby member yet.

[PunkPun]

Needs a rebase, my request of making the join lobby sound consistently play still stands

[Mailaender]

I am a bit confused as I seem to hear my own join/leave sounds.

[PunkPun]

Interesting, something must have changed. Now sounds for leaving are always played, however there's still no sound when entering skirmish

[Mailaender]

Not for skirmish, but when you choose multiplayer you get the sounds. I am not really sure why, because I thought skirmish is just local multiplayer with yourself.

[PunkPun]

It's because when you enter skirmish "Player has joined the lobby" message is not sent

[PunkPun]

OpenRA/OpenRA.Game/Server/Server.cs

Lines 583 to 584 in fa65e7f

	if (Type != ServerType.Local)
	SendLocalizedMessage(Joined, Translation.Arguments("player", client.Name));

[PunkPun]

#6246 (comment)

I'd be fine if this PR just added the tech but didn't change the sounds themselves

[Mailaender]

Removed sounds from the mods.

[PunkPun]

Please add back the sounds. I meant keeping all the sounds as they are, that is the chat sound for everything

[PunkPun]

Changelog