[Superseded] Added try/catch to CheckRevealFootprint #20080
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exceptions like "OpenRA.Utility(1,1): Error: OpenRA.Mods.Common.Lint.CheckDefaultVisibility failed with exception: System.InvalidOperationException: TypeDictionary contains multiple instances of type OpenRA.Traits.IOccupySpaceInfo" are very hard to diagnose, so we'd like to have the actor name to help.
|
To give some context on the |
|
So should this PR be closed and an issue opened instead? |
|
No, I consider this critical enough to fix before a release. Either I finish it or someone takes over. |
|
Closing as superseded by #20188. |
penev92
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exceptions like "OpenRA.Utility(1,1): Error: OpenRA.Mods.Common.Lint.CheckDefaultVisibility failed with exception: System.InvalidOperationException: TypeDictionary contains multiple instances of type OpenRA.Traits.IOccupySpaceInfo" are very hard to diagnose, so we'd like to have the actor name to help.
P.S.: Best seen without the whitespace changes: https://github.com/OpenRA/OpenRA/pull/20080/files?w=1