Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework sequence documentation plumbing #20087

Merged
merged 2 commits into from Jul 2, 2022
Merged

Rework sequence documentation plumbing #20087

merged 2 commits into from Jul 2, 2022

Conversation

pchote
Copy link
Member

@pchote pchote commented Jun 26, 2022 •
edited

Fixes a redundancy noted in #19986 and now changes the way these are implemented.

@pchote pchote added this to the Next release milestone Jun 26, 2022
@pchote pchote requested a review from penev92 June 26, 2022 14:58
@pchote
Copy link
Member Author

pchote commented Jun 26, 2022

Pushed additional fixes as discussed in Discord.

@pchote
Copy link
Member Author

pchote commented Jun 26, 2022 •
edited

After more brainstorming in Discord i'm leaning towards an approach like 2dac6b9 to avoid exposing potentially misleading public fields to non-utility-documentation users.

@pchote pchote force-pushed the embedded-palette branch 2 times, most recently from 149fdb0 to 6ea6541 Compare June 26, 2022 22:15
@pchote pchote changed the title Replace Sequence EmbeddedPalette with HasEmbeddedPalette. Rework sequence documentation plumbing Jun 26, 2022
@pchote
Copy link
Member Author

pchote commented Jun 26, 2022

Updated. This now implements my suggested approach and fixes a few descriptions.

fb9d65b shows how the --sequence-docs utility command could look, but I will leave that to @penev92.

@pchote
Copy link
Member Author

pchote commented Jun 26, 2022

Updated.

This was referenced Jun 27, 2022
Closed
Closed
abcdefg30
abcdefg30 previously approved these changes Jun 28, 2022
View reviewed changes
Copy link
Member

@abcdefg30 abcdefg30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm otherwise.

@penev92 penev92 merged commit c8df1e8 into OpenRA:bleed Jul 2, 2022
@pchote pchote deleted the embedded-palette branch July 2, 2022 11:11
@penev92
Copy link
Member

penev92 commented Jul 2, 2022

Changelog

@Mailaender Mailaender mentioned this pull request Aug 3, 2022
Merged
This was referenced Sep 7, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@penev92 penev92 penev92 approved these changes

@abcdefg30 abcdefg30 abcdefg30 left review comments

Assignees
No one assigned
Labels
PR: Needs +2
Projects
None yet
Milestone
Release 20230225
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pchote @penev92 @abcdefg30