Move PlayerExperience from Infiltrates to InfiltrateFor

[PunkPun]

This allows customisation per InfiltrateFor trait instead of only for the unit infiltrating. This will allow us to determine what infiltration is worth more than the other.

The reward currently is 10 per infiltration I've given a different reward for infiltrating for cash, 5 + 1% for cash stolen
I've also removed XP from infiltrating fakes

[AspectInteractive2]

I think the experience added by infiltration is bugged, as it reset the experience to 0 initially, and then it sets it to 2635 somehow as shown below - there doesn't seem to be a pattern to it. I've tested the original game's experience and normally it increments by 50 per infiltration as you've described in your original post.

[PunkPun]

I think the experience added by infiltration is bugged, as it reset the experience to 0 initially, and then it sets it to 2635 somehow as shown below - there doesn't seem to be a pattern to it. I've tested the original game's experience and normally it increments by 50 per infiltration as you've described in your original post.

It seems I have forgotten to divide InfiltratesForCash percentage by 100. The 2635 was probably meant to be 18.
I additionally nerfed this gain to 5 + 1% and removed XP from infiltrating fakes

[PunkPun]

rebased

[Mailaender]

Needs a small rebase.

[anvilvapre]

Looking at the code for the first time it seems that the InfiltrateFor classes share a lot of the same code. And that this pull request even add more duplicate code to those classes. I.e. you add the same line of code to many files.

There is no way to refactor these classes, let them inherit or make use of a util class?

[PunkPun]

Looking at the code for the first time it seems that the InfiltrateFor classes share a lot of the same code. And that this pull request even add more duplicate code to those classes. I.e. you add the same line of code to many files.

There is no way to refactor these classes, let them inherit or make use of a util class?

I don't think it's necessary, these are fairly tiny traits. A util class wouldn't help much with code sharing as there's actually very little duplicated code here.

[Mailaender]

Needs a rebase.

[PunkPun]

Rebased and update rule fixed

[PunkPun]

Changelog