Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Play Map button to map editor #20120

Merged
merged 3 commits into from Sep 9, 2023
Merged

Conversation

PunkPun
Copy link
Member

@PunkPun PunkPun commented Jul 10, 2022

No description provided.

@PunkPun PunkPun force-pushed the add-play-button branch 5 times, most recently from 5c2a1ae to 47de5ca Compare July 13, 2022 15:50
@PunkPun PunkPun marked this pull request as draft July 13, 2022 19:55
@PunkPun PunkPun force-pushed the add-play-button branch 2 times, most recently from ceb6e3b to 8457b64 Compare July 19, 2022 19:17
@PunkPun PunkPun marked this pull request as ready for review July 19, 2022 19:19
@PunkPun PunkPun force-pushed the add-play-button branch 3 times, most recently from 85029a7 to 2b14bf2 Compare July 19, 2022 21:34
Mailaender
Mailaender previously approved these changes Aug 3, 2022
Copy link
Member

@Mailaender Mailaender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as promised.

dragunoff

This comment was marked as outdated.

@PunkPun

This comment was marked as outdated.

@dragunoff

This comment was marked as outdated.

@PunkPun

This comment was marked as outdated.

@abcdefg30
Copy link
Member

Can we split this and review/merge independently?

Fwiw, I think it would be good to split an extra "go back to the editor"-button PR from this and focus just on editor->ingame here.

@PunkPun PunkPun force-pushed the add-play-button branch 2 times, most recently from 09070ae to 1b3dbdd Compare September 9, 2022 18:19
@PunkPun
Copy link
Member Author

PunkPun commented Sep 9, 2022

Fwiw, I think it would be good to split an extra "go back to the editor"-button PR from this and focus just on editor->ingame here.

I've separated them into commits. I don't think it's worth splitting as this is already a fairly small and self-contained PR. I've already split of 2 PR's from this

@PunkPun PunkPun force-pushed the add-play-button branch 2 times, most recently from b4e39cd to d8e6c1e Compare September 9, 2022 18:38
@PunkPun PunkPun marked this pull request as draft September 22, 2022 13:34
@AspectInteractive2

This comment was marked as outdated.

@PunkPun

This comment was marked as outdated.

@PunkPun PunkPun marked this pull request as ready for review August 23, 2023 18:00
@Mailaender Mailaender merged commit 085a4c4 into OpenRA:bleed Sep 9, 2023
3 checks passed
@Mailaender
Copy link
Member

Changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants