Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align weapons to better match original d2k #20137

Merged

Conversation

Porenutak
Copy link
Contributor

closes #20021
This PR aim to bring ORA D2k closer to original D2k with minimum changes possible. Based on research here: #20021. Testing method was by shooting with each unit into unit blobs of every type from various range. Prone effect applies random in original D2k. To compensate this some weapons have smaller prone effect AoE. Most difference between ORA D2k and orig D2k was with all units VS infantry. (probably because random prone effect or random Prone50Percent triggering). To compensate this, some weapons have more damage against none armor

Detailed statistic are here:

damage comparision.pdf

Changes are inline with #17972

PunkPun
PunkPun previously approved these changes Jul 24, 2022
Copy link
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rockets are still unable to hit aircraft. Was one of the goals to fix that or should it be done in a separate PR?

@Porenutak
Copy link
Contributor Author

Rockets are still unable to hit aircraft. Was one of the goals to fix that or should it be done in a separate PR?

yes, I fix that issue here: #20139

@PunkPun
Copy link
Member

PunkPun commented Jul 24, 2022

yes, I fix that issue here: #20139

That PR doesn't fix missile tracking

@Porenutak
Copy link
Contributor Author

fixed with new commit.

Copy link
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TowerMissile still lacks tracking, it overwrites the inherited HorizontalRateOfTurn: buffs

Missile tank still lacks damage vs infantry, when I tried it took like 17 missiles (instead of suggested 9), I think you forgot the missile tank changes.

Sneaky Ornithopter buff :P

Otherwise LGTM

mods/d2k/weapons/other.yaml Outdated Show resolved Hide resolved
@Porenutak
Copy link
Contributor Author

Ornithopter and Death hand buffs are inline with original. Forgot to mention that in description.

@PunkPun
Copy link
Member

PunkPun commented Jul 24, 2022

Missile tank anti-inf damage still doesn't seem high enough. And there was no rocket turret fix

@Porenutak Porenutak force-pushed the Align-weapons-to-better-match-orginal-D2k branch 2 times, most recently from f65514b to b3de99e Compare July 24, 2022 18:42
@Porenutak Porenutak force-pushed the Align-weapons-to-better-match-orginal-D2k branch from b3de99e to e2a1203 Compare July 24, 2022 19:13
PunkPun
PunkPun previously approved these changes Jul 24, 2022
Copy link
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

PunkPun
PunkPun previously approved these changes Jul 26, 2022
Copy link
Member

@abcdefg30 abcdefg30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small nit picks

mods/d2k/weapons/other.yaml Outdated Show resolved Hide resolved
mods/d2k/weapons/other.yaml Outdated Show resolved Hide resolved
Align ORA D2k weapons to better match original d2k.
@abcdefg30 abcdefg30 merged commit a9d1b77 into OpenRA:bleed Jul 28, 2022
@abcdefg30
Copy link
Member

Changelog

@Porenutak Porenutak deleted the Align-weapons-to-better-match-orginal-D2k branch November 14, 2023 10:08
@Porenutak Porenutak mentioned this pull request Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align OpenRA d2k balance with original D2k
3 participants