Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add descriptions to all projectiles and warheads #20219

Merged
merged 1 commit into from Aug 29, 2022
Merged

Add descriptions to all projectiles and warheads #20219

merged 1 commit into from Aug 29, 2022

Conversation

PunkPun
Copy link
Member

@PunkPun PunkPun commented Aug 24, 2022

I add definitions to all projectiles and warheads, even if some of them don't need it.

This PR has 2 goals:

  • Improve documentation
  • Improve the formatting of our docks page by making sure all elements have descriptions

@PunkPun PunkPun changed the title Add descriptions to projectiles and warheads Add descriptions to all projectiles and warheads Aug 24, 2022
@PunkPun PunkPun force-pushed the weapon-desc branch 2 times, most recently from 5469476 to b727c6f Compare August 24, 2022 11:19
abcdefg30
abcdefg30 reviewed Aug 24, 2022
View reviewed changes
OpenRA.Mods.Common/Projectiles/AreaBeam.cs Outdated Show resolved Hide resolved
OpenRA.Mods.Common/Projectiles/Bullet.cs Outdated Show resolved Hide resolved
OpenRA.Mods.Common/Warheads/SpreadDamageWarhead.cs Outdated Show resolved Hide resolved
OpenRA.Mods.Common/Warheads/LeaveSmudgeWarhead.cs Outdated Show resolved Hide resolved
OpenRA.Mods.Common/Warheads/HealthPercentageDamageWarhead.cs Outdated Show resolved Hide resolved
OpenRA.Mods.Common/Warheads/FireClusterWarhead.cs Outdated Show resolved Hide resolved
OpenRA.Mods.Common/Warheads/CreateEffectWarhead.cs Outdated Show resolved Hide resolved
OpenRA.Mods.Cnc/Projectiles/TeslaZap.cs Outdated Show resolved Hide resolved
OpenRA.Mods.Common/Projectiles/GravityBomb.cs Outdated Show resolved Hide resolved
@PunkPun PunkPun force-pushed the weapon-desc branch 2 times, most recently from 6392d06 to b6a1f9a Compare August 25, 2022 08:02
abcdefg30
abcdefg30 approved these changes Aug 25, 2022
View reviewed changes
Copy link
Member

@abcdefg30 abcdefg30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@penev92 penev92 merged commit d3589c0 into OpenRA:bleed Aug 29, 2022
@penev92
Copy link
Member

penev92 commented Aug 29, 2022

Changelog

@PunkPun PunkPun deleted the weapon-desc branch August 29, 2022 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dragunoff dragunoff dragunoff approved these changes

@abcdefg30 abcdefg30 abcdefg30 approved these changes

Assignees
No one assigned
Labels
PR: Needs +2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@PunkPun @penev92 @dragunoff @abcdefg30