Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce MinDistance to AreaBeam projectile #20244

Merged
merged 1 commit into from Nov 17, 2022
Merged

Introduce MinDistance to AreaBeam projectile #20244

merged 1 commit into from Nov 17, 2022

Conversation

PunkPun
Copy link
Member

@PunkPun PunkPun commented Sep 1, 2022

Superseding #20170

@PunkPun
Copy link
Member Author

PunkPun commented Sep 8, 2022

TS disrupters only shot as far as they aimed, so no need to adjust them

@penev92 penev92 added this to the Next release milestone Sep 11, 2022
AspectInteractive2
AspectInteractive2 approved these changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@AspectInteractive2 AspectInteractive2 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, the logic is correct and is well implemented.

@Mailaender Mailaender merged commit a9da6bb into OpenRA:bleed Nov 17, 2022
@Mailaender
Copy link
Member

Changelog

@Mailaender
Copy link
Member

Changelog

@PunkPun PunkPun deleted the area-beam branch November 17, 2022 20:04
@abcdefg30
Copy link
Member

For reference, the prep commit: c01e404

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@penev92 penev92 penev92 left review comments

@AspectInteractive2 AspectInteractive2 AspectInteractive2 approved these changes

Assignees
No one assigned
Labels
PR: For stable PR: Needs +2
Projects
None yet
Milestone
Release 20230225
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@PunkPun @Mailaender @abcdefg30 @AspectInteractive2 @penev92