Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ShroudRenderer, fix, no shroud or fog in editor. #20253

Merged
merged 1 commit into from Sep 3, 2022
Merged

ShroudRenderer, fix, no shroud or fog in editor. #20253

merged 1 commit into from Sep 3, 2022

Conversation

anvilvapre
Copy link
Contributor

@anvilvapre anvilvapre commented Sep 3, 2022 •
edited by Smittytron

Closes #20252

RoosterDragon
RoosterDragon previously approved these changes Sep 3, 2022
View reviewed changes
@MustaphaTR
Copy link
Member

MustaphaTR commented Sep 3, 2022 •
edited

Still not right. The area outside of map bounds should be shown as if it is under FoW. It is missing currently:
resim
How it should be:
resim

@anvilvapre anvilvapre force-pushed the 20220903_shroud_renderer_edges_fix2 branch from 8849c01 to 21b856a Compare September 3, 2022 12:07
@Mailaender Mailaender merged commit 63499c6 into OpenRA:bleed Sep 3, 2022
@Mailaender
Copy link
Member

Changelog

@Smittytron Smittytron mentioned this pull request Sep 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RoosterDragon RoosterDragon RoosterDragon approved these changes

@MustaphaTR MustaphaTR MustaphaTR approved these changes

Assignees
No one assigned
Labels
PR: Needs +2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Map appears all black on the Editor.
5 participants
@anvilvapre @MustaphaTR @Mailaender @RoosterDragon @PunkPun