Move ValidRelations from Capturable to Captures

[PunkPun]

When working on adding auto-target for Captures I noticed that valid player relationships is defined on Capturable instead of Captures. This is the complete opposite of how we define weapons, we put ValidRelations on warheads and projectiles. Not on the targets.

[penev92]

I think if we want a real improvement (in flexibility) we should have both. Otherwise this is simply moving stuff around for no actual gain (well yes, consistency).

[PunkPun]

we gain the ability to treat capturing as a weapon, if we keep on the capturee we'll lose that again

[penev92]

Okay, how do you denote that "this is a special structure that can be captured by an/any friendly capturing unit (engineer)"?
And how do you think that compares to "this unit type (or types) can capture any friendly structure" use-case-wise?

[PunkPun]

See TD engineer in this PR. For me this is a necessary step towards Captures auto-target implementation, the added benefit is consistentsy

[RoosterDragon]

Motivations seem reasonable enough to me.

[MustaphaTR]

I did some tests, there seem to be some regression in TD mod. With the setup below, i see red cursor on my and AIs husks and despite red cursor showing up on AI's PP i can capture it with one engineer. Neutral and Creeps ones show green cursor as normal and are also one-engi capture.

[PunkPun]

Fixed

[Mailaender]

Changelog