Disallow saving game with an empty name field #20273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PunkPun
changed the title
PunkPun
previously approved these changes
Sep 8, 2022
abcdefg30
reviewed
Sep 8, 2022
| @@ -112,6 +112,7 @@ public GameSaveBrowserLogic(Widget widget, ModData modData, Action onExit, Actio | |||
| } | |||
|
|
|||
| var saveButton = panel.Get<ButtonWidget>("SAVE_BUTTON"); | |||
| saveButton.IsDisabled = () => string.IsNullOrEmpty(saveTextField.Text); | |||
There was a problem hiding this comment.
I suggest
Suggested change
| saveButton.IsDisabled = () => string.IsNullOrEmpty(saveTextField.Text); | |
| saveButton.IsDisabled = () => string.IsNullOrWhiteSpace(saveTextField.Text); |
since we don't want to allow spaces as file names either.
The-Zen-Cat
force-pushed
the
savewithoutnamebug
branch
from
70c5f7d
to
53bd75c
Compare
dragunoff
previously approved these changes
Sep 9, 2022
PunkPun
force-pushed
the
savewithoutnamebug
branch
from
53bd75c
to
cff1ea8
Compare
PunkPun
approved these changes
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20233
Disallow game save with empty name field by disabling save button until text input is present.