-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added back checks for difficulty on a per map basis #20281
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was exactly the concern I raised in #19738 so the motivation seems reasonable to me.
Changing this back and forth really seems counter intuitive to me. (We would have to revert the changes here sooner or later again.) Neither the lookups nor the debug messages seem like enough justification to change this back for me. |
Makes sense. What do you think about adding a new API like |
That sounds like a good compromise. |
0e59478
to
606b322
Compare
Yes, that is a way better idea. |
606b322
to
71ff6fe
Compare
71ff6fe
to
c9bac25
Compare
c9bac25
to
338e0ba
Compare
as this causes unnecessary lookups and error messages in
debug.log
for maps without difficulty configured.