Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added back checks for difficulty on a per map basis #20281

Merged
merged 2 commits into from
May 21, 2023

Conversation

Mailaender
Copy link
Member

as this causes unnecessary lookups and error messages in debug.log for maps without difficulty configured.

Copy link
Member

@pchote pchote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was exactly the concern I raised in #19738 so the motivation seems reasonable to me.

mods/ra/scripts/campaign.lua Show resolved Hide resolved
@abcdefg30
Copy link
Member

This was exactly the concern I raised in #19738 so the motivation seems reasonable to me.

Changing this back and forth really seems counter intuitive to me. (We would have to revert the changes here sooner or later again.) Neither the lookups nor the debug messages seem like enough justification to change this back for me.

@pchote
Copy link
Member

pchote commented Dec 20, 2022

Makes sense. What do you think about adding a new API like Map.LobbyOptionOrDefault("difficulty", "normal")?

@abcdefg30
Copy link
Member

That sounds like a good compromise.

@Mailaender
Copy link
Member Author

Yes, that is a way better idea.

abcdefg30
abcdefg30 previously approved these changes Feb 1, 2023
@PunkPun PunkPun merged commit 0fb5853 into OpenRA:bleed May 21, 2023
3 checks passed
@PunkPun
Copy link
Member

PunkPun commented May 21, 2023

Changelog

@Mailaender Mailaender deleted the lua-difficulty-revert branch May 21, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants